Allow for setting the minimum supported WP version from the command line #1094
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the comments made here: #826 (comment)
This change allows for setting the
minimum_supported_version
property for all threeWP.Deprecated...
sniffs in one go, either via the command-line or by setting a config variable in a custom ruleset.As this config variable is no longer directly related to a sniff, I've chosen to make the name slightly more specific/descriptive:
minimum_supported_wp_version
<= note the_wp_
.Usage:
phpcs . --standard=WordPress --runtime-set minimum_supported_wp_version 4.5
or in a ruleset:
The above one liner can replace the custom property which would otherwise need to be set for all three sniffs individually.
Overrule order:
<config>
property in the ruleset<property>
's set via the rulesetSimplest way to test this is by running PHPCS over the
WP.DeprecatedParameter
sniff unit tests:Additional notes:
$custom_test_class_whitelist
property up in theWordPress\Sniff
class, so bothpublic
properties are now at the top of the file.To do once this PR is merged: